Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add DRPC tailnet & cli implementation for network telemetry #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

chore: add DRPC tailnet & cli implementation for network telemetry #13677

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
20e59e0
ci: test with multiple postgres versions (#13665)
johnstcn Jun 26, 2024
e8e0064
chore: add DRPC tailnet & cli implementation
ethanndickson Jun 26, 2024
3819274
fixup
ethanndickson Jun 26, 2024
5b1e1f9
fixup
ethanndickson Jun 26, 2024
08e728b
chore: implement organization scoped audit log requests (#13663)
Emyrk Jun 26, 2024
30c4b4d
chore: implement fetch all authorized templates api (#13678)
Emyrk Jun 26, 2024
c4f1676
feat: expose workspace build ID to terraform-plugin-coder (#13680)
mtojek Jun 27, 2024
5b59f28
fix: fix workspacesdk to return error on API mismatch (#13683)
spikecurtis Jun 27, 2024
c94b518
fix: modify workspacesdk to ask for tailnet API 2.0 (#13684)
spikecurtis Jun 27, 2024
6cd8c43
chore: add DRPC server implementation for network telemetry
deansheather Jun 26, 2024
305fd2b
Progress
deansheather Jun 27, 2024
4e3671e
chore: add DRPC tailnet & cli implementation
ethanndickson Jun 26, 2024
b7870d2
fixup
ethanndickson Jun 26, 2024
a7eca55
fixup
ethanndickson Jun 26, 2024
78a2e4a
Merge branch '06-26-chore_add_drpc_tailnet_cli_implementation' of htt…
ethanndickson Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: modify workspacesdk to ask for tailnet API 2.0 (#13684) 
#13617 bumped the Agent/Tailnet API minor version because it adds telemetry features.  However, we don't actually use the protocol features yet, so it's a bit obnoxious for our CLI client to ask for the newest API version.

This is particularly true of the CLI client, since that's distributed separately, so if an end user installs the latest CLI client and their organization hasn't fully upgraded, then it will fail to connect.

Since we have a release coming up and the telemetry stuff won't make it, I think we should roll back to version 2.0 until we actually implement the telemetry stuff. That way the newest release (2.13) will work with Coder servers all the way back to 2.9.
  • Loading branch information
@spikecurtis
spikecurtis authored Jun 27, 2024
commit c94b5188bd2a48dba26032efe23e5f5530a1ebcc
11 changes: 9 additions & 2 deletions codersdk/workspacesdk/workspacesdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"cdr.dev/slog"
"github.com/coder/coder/v2/codersdk"
"github.com/coder/coder/v2/tailnet"
"github.com/coder/coder/v2/tailnet/proto"
)

// AgentIP is a static IPv6 address with the Tailscale prefix that is used to route
Expand Down Expand Up @@ -241,7 +240,15 @@ func (c *Client) DialAgent(dialCtx context.Context, agentID uuid.UUID, options *
return nil, xerrors.Errorf("parse url: %w", err)
}
q := coordinateURL.Query()
q.Add("version", proto.CurrentVersion.String())
// TODO (ethanndickson) - the current version includes 2 additions we don't currently use:
//
// 2.1 GetAnnouncementBanners on the Agent API (version locked to Tailnet API)
// 2.2 PostTelemetry on the Tailnet API
//
// So, asking for API 2.2 just makes us incompatible back level servers, for no real benefit.
// As a temporary measure, we'll specifically ask for API version 2.0 until we implement sending
// telemetry.
q.Add("version", "2.0")
coordinateURL.RawQuery = q.Encode()

connector := runTailnetAPIConnector(ctx, options.Logger,
Expand Down
Loading