Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add DRPC tailnet & cli implementation for network telemetry #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jun 26, 2024

  • Adds a TelemetrySink interface to tailnet.Conn to support sending network telemetry events regardless of source.
  • Adds a TelemetrySink implemention for tailnetApiConnector, to be used by the CLI.
  • Adds a way to disable network telemetry from the CLI

TODO:

  • Tests

johnstcn and others added 2 commits June 26, 2024 16:22
- Tests now run on postgres 16 by default when run locally (can be specified with POSTGRES_VERSION)
- Adds test-go-pg-16 to test against postgres version 16
- Updates Dogfood dockerfile / nix flake to postgres version 16
- Updates docker-compose.yaml postgres tag to 16
Copy link
Member Author

ethanndickson commented Jun 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson changed the title chore: add DRPC tailnet & cli implementation chore: add DRPC tailnet & cli implementation for network telemetry Jun 26, 2024
spikecurtis and others added 7 commits June 27, 2024 15:38
#13617 bumped the Agent/Tailnet API minor version because it adds telemetry features.  However, we don't actually use the protocol features yet, so it's a bit obnoxious for our CLI client to ask for the newest API version.

This is particularly true of the CLI client, since that's distributed separately, so if an end user installs the latest CLI client and their organization hasn't fully upgraded, then it will fail to connect.

Since we have a release coming up and the telemetry stuff won't make it, I think we should roll back to version 2.0 until we actually implement the telemetry stuff. That way the newest release (2.13) will work with Coder servers all the way back to 2.9.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@ethanndickson ethanndickson deleted the 06-26-chore_add_drpc_tailnet_cli_implementation branch July 3, 2024 05:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants