chore: add DRPC tailnet & cli network telemetry #13687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
937bf83 to
479df1f
Compare
c4b57b9 to
09f375b
Compare
9482c1c to
b9cd8fb
Compare
deansheather
approved these changes
Jul 2, 2024
| @@ -108,8 +108,7 @@ message IPFields { | |||
| PUBLIC = 0; | |||
| PRIVATE = 1; | |||
| LINK_LOCAL = 2; | |||
| UNIQUE_LOCAL = 3; | |||
| LOOPBACK = 4; | |||
| LOOPBACK = 3; | |||
There was a problem hiding this comment.
As per Slack discussion, UNIQUE_LOCAL was removed in favor of { v=4, class=PRIVATE } meaning "ipv4 private range" and { v=6, class=PRIVATE } meaning unique local.
|
|
||
| message NetcheckIP { | ||
| string hash = 1; | ||
| IPFields fields = 2; | ||
| } | ||
| NetcheckIP GlobalV4 = 17; | ||
| NetcheckIP GlobalV6 = 18; | ||
|
|
||
| google.protobuf.BoolValue CaptivePortal = 19; |
There was a problem hiding this comment.
This was removed because captive portal checks are disabled in Coder's tailscale fork anyways
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TelemetrySinkinterface totailnet.Connto support sending network telemetry events regardless of source.TelemetrySinkimplemention fortailnetApiConnector, to be used by the CLI.TelemetryStoreto atailnet.Connto store and scrub PII from any data used to construct network telemetry events.coder speedtest,coder ping, when a workspace agent is reachable, and when an ssh connection session ends.A future PR will implement the plumbing necessary to record: