refactor: Improve the load state for the list pages #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age-loader-design
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 67.26% 67.18% -0.09%
==========================================
Files 288 291 +3
Lines 19422 19452 +30
Branches 244 258 +14
==========================================
+ Hits 13065 13068 +3
- Misses 5019 5046 +27
Partials 1338 1338
Continue to review full report at Codecov.
|
Contributor
Author
|
Close #1434 |
Kira-Pilot
reviewed
May 13, 2022
| ))} | ||
|
|
||
| {users.length === 0 && ( | ||
| {users && users.length === 0 && ( |
Member
There was a problem hiding this comment.
Maybe next time we're in here, we can break this file apart a bit.
Kira-Pilot
approved these changes
May 13, 2022
Member
Kira-Pilot
left a comment
There was a problem hiding this comment.
Nice job! This looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkspacesPageandWorkspacePageto use not use the customTablecomponent and created the componentsWorkspacesTableandTemplatesTablewith related storybooks covering theempty,defaultandloadingstates so we can trust on storybook to test them for us.