Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add 'hidden' option to 'coder_app' to hide app from UI #14570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 9, 2024

Conversation

DanielleMaywood
Copy link
Contributor

Resolves #13265

Adds support for the hidden field added to a workspace app. This field allows hiding an app from the user interface.

Screen.Recording.2024-09-05.at.10.08.02.mp4

@DanielleMaywood DanielleMaywood changed the title WIP: feat: add 'hidden' option to 'coder_app' to hide app from UI feat: add 'hidden' option to 'coder_app' to hide app from UI Sep 5, 2024
@DanielleMaywood DanielleMaywood marked this pull request as ready for review September 5, 2024 12:08
@DanielleMaywood DanielleMaywood marked this pull request as draft September 5, 2024 12:09
@DanielleMaywood DanielleMaywood marked this pull request as ready for review September 5, 2024 15:40
@mtojek mtojek requested review from mtojek and johnstcn September 6, 2024 06:56
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a very quick PR, great work! I raised a concern about potential conflicts in the agent properties' values. If it's too difficult or impractical to safely introduce validation, I would recommend leaving it as is.

@DanielleMaywood DanielleMaywood force-pushed the dm-allow-hide-coder_app-button branch from ab0e0ca to ed9791e Compare September 6, 2024 09:58
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a story for this but apart from that LGTM 👍

@mtojek
Copy link
Member

mtojek commented Sep 6, 2024

Folks, are we going to release the provider changes first, and then update go.mod here?

@johnstcn
Copy link
Member

johnstcn commented Sep 6, 2024

Folks, are we going to release the provider changes first, and then update go.mod here?

☝️ Forgot about this!

@DanielleMaywood DanielleMaywood force-pushed the dm-allow-hide-coder_app-button branch from e04d1c1 to c8b9425 Compare September 9, 2024 13:01
@johnstcn johnstcn requested a review from mtojek September 9, 2024 13:20
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanielleMaywood DanielleMaywood merged commit 25f1ddb into main Sep 9, 2024
30 of 32 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-allow-hide-coder_app-button branch September 9, 2024 13:39
Emyrk pushed a commit that referenced this pull request Sep 9, 2024
Add 'hidden' property to 'coder_app' resource to allow hiding apps from the UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally hide coder_app button in dashboard
3 participants