-
Notifications
You must be signed in to change notification settings - Fork 943
feat: add 'hidden' option to 'coder_app' to hide app from UI #14570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a very quick PR, great work! I raised a concern about potential conflicts in the agent properties' values. If it's too difficult or impractical to safely introduce validation, I would recommend leaving it as is.
ab0e0ca
to
ed9791e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding a story for this but apart from that LGTM 👍
Folks, are we going to release the provider changes first, and then update |
☝️ Forgot about this! |
The existing description is the opposite of what the field actually says. Co-authored-by: Cian Johnston <[email protected]>
e04d1c1
to
c8b9425
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Add 'hidden' property to 'coder_app' resource to allow hiding apps from the UI.
Resolves #13265
Adds support for the
hidden
field added to a workspace app. This field allows hiding an app from the user interface.Screen.Recording.2024-09-05.at.10.08.02.mp4