Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: show paywall and correctly display auto create groups for IDP sync #14800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Sep 25, 2024

Update the UI to look as seen below for a non-licensed user.

Premium Banner

Screenshot 2024-09-25 at 9 15 41 PM

Loading State

Screenshot 2024-09-25 at 9 12 45 PM

Error State

Screenshot 2024-09-25 at 9 12 55 PM

@jaaydenh jaaydenh self-assigned this Sep 25, 2024
@jaaydenh jaaydenh requested review from a team and Kira-Pilot and removed request for a team September 25, 2024 15:41
@Kira-Pilot Kira-Pilot requested review from aslilac and Parkreiner and removed request for Kira-Pilot September 25, 2024 15:48
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the story updates look good. The main concern with the current fix is that it might be set up in a way that could annoy the user

Comment on lines 69 to 71
<Paywall
message="IdP Sync"
description="Configure group and role mappings to manage permissions outside of Coder. You need an Premium license to use this feature."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rendering properly? The paywall in the screenshot has alignment values all over the place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there were previously 2 changes to increase the text length of the right side bullet points and make the banner overall wider. Can you create a new issue for the improvements you would like to see?

@jaaydenh jaaydenh force-pushed the jaaydenh/idp-sync-fixes branch from 0de6a57 to 052f9c1 Compare September 26, 2024 01:10
@jaaydenh jaaydenh requested a review from Parkreiner September 26, 2024 01:16
@jaaydenh
Copy link
Contributor Author

@aslilac I rearranged the Loader, ErrorAlert and Paywall. I tried to find a away to avoid the nested ternary that you used for Provisioners in hopes that this is easier to reason about.

Overall, this allows using the using Loader, ErrorAlert and Paywall in the proper order and displays everything under the Settings Header.

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! thank you!

Comment on lines +74 to +81
<Button
startIcon={<LaunchOutlined />}
component="a"
href={docs("/admin/auth#group-sync-enterprise")}
target="_blank"
>
Setup IdP Sync
</Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to hide this button on the provisioners page, since the page is telling the user they're not allowed to use the feature. maybe it's fine since it just links to the docs tho. wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just left it because its only a docs button.

@jaaydenh jaaydenh merged commit 9ea2f6f into main Sep 26, 2024
33 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/idp-sync-fixes branch September 26, 2024 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants