-
Notifications
You must be signed in to change notification settings - Fork 883
fix: show paywall and correctly display auto create groups for IDP sync #14800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the story updates look good. The main concern with the current fix is that it might be set up in a way that could annoy the user
site/src/pages/ManagementSettingsPage/IdpSyncPage/IdpSyncPage.tsx
Outdated
Show resolved
Hide resolved
<Paywall | ||
message="IdP Sync" | ||
description="Configure group and role mappings to manage permissions outside of Coder. You need an Premium license to use this feature." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rendering properly? The paywall in the screenshot has alignment values all over the place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there were previously 2 changes to increase the text length of the right side bullet points and make the banner overall wider. Can you create a new issue for the improvements you would like to see?
0de6a57
to
052f9c1
Compare
@aslilac I rearranged the Overall, this allows using the using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! thank you!
<Button | ||
startIcon={<LaunchOutlined />} | ||
component="a" | ||
href={docs("/admin/auth#group-sync-enterprise")} | ||
target="_blank" | ||
> | ||
Setup IdP Sync | ||
</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to hide this button on the provisioners page, since the page is telling the user they're not allowed to use the feature. maybe it's fine since it just links to the docs tho. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I just left it because its only a docs button.
Update the UI to look as seen below for a non-licensed user.
Premium Banner
Loading State
Error State