-
Notifications
You must be signed in to change notification settings - Fork 881
chore(site): use .gitignore
in biome.jsonc
#16026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.gitignore
in biome.jsonc
.gitignore
in biome.jsonc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we keep biome.json(c) in project root since it's used project-wide? Other than that, this looks alright to me but I'll leave final approval for @aslilac.
because it isn't, it's only used inside site/ |
Maybe we should. |
Oh, we used to use prettier to format YAML and JSON outside of site in the past. So I assumed. Are we using something else now? |
we were still using prettier, but it's been ripped out now 😅 biome doesn't even support yaml, so we can't use it for that |
Looks like prettier has to come back for YAML at least. |
@aslilac is it ok to merge for now? Or do you have any suggestions? |
Following up on a comment in #15831, we can use the ignore file from VCS in biome.