Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(site): use .gitignore in biome.jsonc #16026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

matifali
Copy link
Member

@matifali matifali commented Jan 3, 2025

Following up on a comment in #15831, we can use the ignore file from VCS in biome.

@matifali matifali requested review from mafredri and aslilac January 3, 2025 14:25
@matifali matifali self-assigned this Jan 3, 2025
@matifali matifali changed the title chore: use .gitignore in biome.jsonc chore(site): use .gitignore in biome.jsonc Jan 3, 2025
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we keep biome.json(c) in project root since it's used project-wide? Other than that, this looks alright to me but I'll leave final approval for @aslilac.

@aslilac
Copy link
Member

aslilac commented Jan 3, 2025

Why don't we keep biome.json(c) in project root since it's used project-wide?

because it isn't, it's only used inside site/

@matifali
Copy link
Member Author

matifali commented Jan 3, 2025

Maybe we should. offlinedocs is still using eslint.

@mafredri
Copy link
Member

mafredri commented Jan 3, 2025

Why don't we keep biome.json(c) in project root since it's used project-wide?

because it isn't, it's only used inside site/

Oh, we used to use prettier to format YAML and JSON outside of site in the past. So I assumed. Are we using something else now?

@aslilac
Copy link
Member

aslilac commented Jan 3, 2025

we were still using prettier, but it's been ripped out now 😅

biome doesn't even support yaml, so we can't use it for that

@matifali
Copy link
Member Author

matifali commented Jan 4, 2025

Looks like prettier has to come back for YAML at least.

@matifali
Copy link
Member Author

matifali commented Jan 5, 2025

@aslilac is it ok to merge for now? Or do you have any suggestions?

@matifali matifali merged commit c41254b into main Jan 7, 2025
32 checks passed
@matifali matifali deleted the atif/use-gitignore-in-biome branch January 7, 2025 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants