Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: reduce Windows PG tests flakiness #16090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2025
Merged

chore: reduce Windows PG tests flakiness #16090

merged 4 commits into from
Jan 10, 2025
+4 −27

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented Jan 10, 2025 •
edited
Loading

This PR:

  • Reduces test parallelism on Windows in CI
  • Unifies wait intervals on Windows with Linux and macOS. Previously we had custom intervals for Windows to reduce test flakiness on smaller CI workers, but we don't run tests on small CI workers anymore. Due to how our CI file is defined, forks run tests on small CI machines, but I'm not sure if the different intervals actually help or whether that's a heuristic that happened to fix issues on a particular day and was it ever reevaluated. I propose we make the change and if someone complains, revert it.

In particular, reduced test parallelism seems to actually help: I was able to run Windows tests 5 times in a row without flakes. Not sure if that's going to fix the problem long term, but it seems worth trying.

@hugodutka hugodutka changed the title chore: remove custom wait durations for windows tests chore: reduce Windows PG tests flakiness Jan 10, 2025
@hugodutka hugodutka marked this pull request as ready for review January 10, 2025 13:37
@hugodutka hugodutka mentioned this pull request Jan 10, 2025
Open
mafredri
mafredri approved these changes Jan 10, 2025
View reviewed changes
testutil/duration.go
@@ -1,5 +1,3 @@
//go:build !windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has me worried due to previously not only Windows runners being underpowered but disk I/O was always slower on Windows too. Feel free to have a go at this but I'd advice to be prepared to revert it 😄

johnstcn
johnstcn approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot 👍

@hugodutka hugodutka merged commit 899836d into main Jan 10, 2025
42 checks passed
@hugodutka hugodutka deleted the hugodutka/windows-test-wait-durations branch January 10, 2025 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

Assignees

@hugodutka hugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugodutka @mafredri @johnstcn