docs: fix broken links #16179
Merged
docs: fix broken links #16179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the URL suffix we append to DeploymentValues.DocsURL to generate stable links for health messages. Adds missing test case coverage for custom docs URL from deployment values.
|
/cherry-pick release/2.18 |
matifali
approved these changes
Jan 17, 2025
| @@ -19,5 +19,6 @@ ignorePatterns: | |||
| - pattern: "code.visualstudio.com" | |||
| - pattern: "www.emacswiki.org" | |||
| - pattern: "linux.die.net/man" | |||
| - pattern: "www.gnu.org" | |||
There was a problem hiding this comment.
I wonder why we need to ignore this.
There was a problem hiding this comment.
that site probably blocks however linkspector is checking responses, so even though the site is there, the check fails: https://github.com/coder/coder/actions/runs/12834052725/job/35790477857#step:5:240
| @@ -24,7 +24,7 @@ workspaces using Coder's [JFrog Xray Integration](https://github.com/coder/coder | |||
| 1. Create a JFrog Platform [Access Token](https://jfrog.com/help/r/jfrog-platform-administration-documentation/access-tokens) with a user that has the `read` [permission](https://jfrog.com/help/r/jfrog-platform-administration-documentation/permissions) | |||
| for the repositories you want to scan. | |||
|
|
|||
| 1. Create a Coder [token](../../reference/cli/tokens_create.md#tokens-create) with a user that has the [`owner`](../users#roles) role. | |||
| 1. Create a Coder [token](../../reference/cli/tokens_create.md#tokens-create) with a user that has the [`owner`](../users/index.md#roles) role. | |||
There was a problem hiding this comment.
This is interesting find. I wonder why it was not flagged by the linkchecker.
|
Cherry-pick failed with |
|
Post-merge approval 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.