-
Notifications
You must be signed in to change notification settings - Fork 881
feat: add tool to send a test notification #16611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No notes! LGTM
Thanks for considering the dedupe logic; good thing OOM/OOD exposed you to this - not considering that could've led to a lot of confusion.
// a second one. We are injecting a timestamp to make the | ||
// notifications appear different enough to circumvent this | ||
// deduplication logic. | ||
"timestamp": api.Clock.Now(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Relates to #16463
Adds a CLI command, and API endpoint, to trigger a test notification for administrators of a deployment.