Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add tool to send a test notification #16611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 19, 2025
Merged

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Feb 18, 2025

Relates to #16463

Adds a CLI command, and API endpoint, to trigger a test notification for administrators of a deployment.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review February 19, 2025 11:01
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes! LGTM
Thanks for considering the dedupe logic; good thing OOM/OOD exposed you to this - not considering that could've led to a lot of confusion.

// a second one. We are injecting a timestamp to make the
// notifications appear different enough to circumvent this
// deduplication logic.
"timestamp": api.Clock.Now(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@DanielleMaywood DanielleMaywood merged commit d2419c8 into main Feb 19, 2025
34 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-test-notification branch February 19, 2025 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants