chore: fix regex bug in migration number fixer#16822
Merged
Merged
Conversation
dannykopping
force-pushed
the
dk/migration-merge
branch
from
March 6, 2025 05:58
804d826 to
0a5d131
Compare
dannykopping
commented
Mar 6, 2025
dannykopping
marked this pull request as draft
March 6, 2025 07:01
dannykopping
force-pushed
the
dk/migration-merge
branch
2 times, most recently
from
March 6, 2025 07:03
fcb516a to
1208852
Compare
dannykopping
marked this pull request as ready for review
March 6, 2025 07:06
Signed-off-by: Danny Kopping <[email protected]>
main
dannykopping
force-pushed
the
dk/migration-merge
branch
from
March 6, 2025 07:11
1208852 to
14f0f98
Compare
mafredri
approved these changes
Mar 6, 2025
Member
There was a problem hiding this comment.
I checked both the grep on macOS (2.6.0-FreeBSD) as well as GNU grep (3.11) and I can't figure out why this would produce different results on any version of grep. The only difference I see here is that we now allow :: and //, etc.
Or are you suggesting that a remote may be named Edit: I re-read your description and that was indeed what you were going for. I thought ^this is an illegal format on GitHub but if not, have at it 👍🏻github.com:/coder/coder and you wanted to add support for that?
Approving to unblock though since it's not a harmful change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a slight regex bug on Bash 5, where
[:/]would only match:but not both:/.The former will actually cause the whole script to bork because of
pipefail, sincegrepexits 1.