Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: use consistent examples in prometheus doc and add namespaceSelector spec #16918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

docs: use consistent examples in prometheus doc and add namespaceSelector spec #16918

merged 1 commit into from
Mar 14, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Mar 13, 2025 •
edited
Loading

closes: #15385

@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Mar 13, 2025
@EdwardAngert EdwardAngert self-assigned this Mar 13, 2025
johnstcn
johnstcn approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with renaming; prom-http was simply shorter to write but I missed the wider context. Good callout with the namespaceSelector!

@matifali matifali removed their request for review March 13, 2025 20:59
@EdwardAngert
Copy link
Contributor Author

@johnstcn 🙌

I'm fine with renaming; prom-http was simply shorter to write but I missed the wider context. Good callout with the namespaceSelector!

I'm into it - less typing and I'm less likely to typo :shipit:

@EdwardAngert EdwardAngert merged commit cf7d143 into main Mar 14, 2025
34 checks passed
@EdwardAngert EdwardAngert deleted the 15385-prometheus branch March 14, 2025 02:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@bpmct bpmct Awaiting requested review from bpmct

@stirby stirby Awaiting requested review from stirby

Assignees

@EdwardAngert EdwardAngert

Labels
docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc Issues Prometheus Integration
2 participants
@EdwardAngert @johnstcn