chore(cli): refactor TestServer/Prometheus to use testutil.Eventually#17295
Merged
chore(cli): refactor TestServer/Prometheus to use testutil.Eventually#17295
Conversation
mafredri
approved these changes
Apr 8, 2025
Member
mafredri
left a comment
There was a problem hiding this comment.
I don't mind the switch to testutil, but we should fix the underlying cause for these flakes (the random port that gets reallocated by other tests).
| defer cancel() | ||
|
|
||
| ctx := testutil.Context(t, testutil.WaitLong) | ||
| randPort := testutil.RandomPort(t) |
Member
There was a problem hiding this comment.
In my experience, this is a huge culprit for this test flaking. But fixing it is tricky, we'd have to 1) start a listener and hand it over to the cmd, or 2) use :0 but somehow signal the test what port to access.
Member
Author
There was a problem hiding this comment.
Yeah agreed -- follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates coder/internal#282
Refactors existing tests to use
testutil.Eventuallywhich plays nicer withtestutil.Context.