I don't feel like coderd should be telling the provisioner what it's version is. This would break on deployments with external provisioners that are on an older version. and I know that's not really a thing we prioritize supporting, but this masks over the mismatched versions in a bad way.

Coderd does not tell the provisioner.

External provisioners call coderd via provisionerDaemonServe

In that, they add a query param of their version:

Which is saved to the DB, and what we show on the provisioners page:

And in that serve function, that apiVersion is sent to the go routine that manages the gRPC connection:

So the apiVersion in that NewServer is the Coderd side of the provisioner. And that version is sourced from the external provisionerd

The daemon client sends the version here:

Idk why it sets it twice

hmm. I don't like this. I would much prefer if we could have a way to expose this naturally to the frontend, forcing it over to the classic form. why make everyone click the "dynamic parameters suck" button? that's a super bad first impression

You are right, it is unfortunate. I want to get this in first, just to get an error up if someone toggles on dev and get this detection in. I will build on this experience.

We just need something now, otherwise it fails silently.