feat: persist AI task state in template imports & workspace builds #18449
+2,773
−530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9848749 to
213ba4a
Compare
Signed-off-by: Danny Kopping <[email protected]> # Conflicts: # go.sum
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
…e changed Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
…tions, add test Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
…required Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]> # Conflicts: # go.sum
Signed-off-by: Danny Kopping <[email protected]>
d240c0e to
0b2b732
Compare
…is PR This will be done in a separate PR Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
commented
Jun 23, 2025
| @@ -584,8 +584,6 @@ func (r *Runner) runTemplateImport(ctx context.Context) (*proto.CompletedJob, *p | |||
| externalAuthProviderNames = append(externalAuthProviderNames, it.Id) | |||
| } | |||
|
|
|||
| // fmt.Println("completed job: template import: graph:", startProvision.Graph) | |||
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
johnstcn
reviewed
Jun 24, 2025
Comment on lines
8
to
23
| -- if has_ai_task is true, ai_task_sidebar_app_id MUST be set | ||
| -- ai_task_sidebar_app_id can ONLY be set if has_ai_task is true | ||
| -- | ||
| -- has_ai_task | ai_task_sidebar_app_id | Result | ||
| -- ------------|------------------------|--------------- | ||
| -- NULL | NULL | TRUE (passes) | ||
| -- NULL | NOT NULL | FALSE (fails) | ||
| -- FALSE | NULL | TRUE (passes) | ||
| -- FALSE | NOT NULL | FALSE (fails) | ||
| -- TRUE | NULL | FALSE (fails) | ||
| -- TRUE | NOT NULL | TRUE (passes) | ||
| ALTER TABLE workspace_builds | ||
| ADD CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required CHECK ( | ||
| ((has_ai_task IS NULL OR has_ai_task = false) AND ai_task_sidebar_app_id IS NULL) | ||
| OR (has_ai_task = true AND ai_task_sidebar_app_id IS NOT NULL) | ||
| ); |
There was a problem hiding this comment.
I originally wondered why has_ai_task was nullable by default, but the provisionerdserver changes below explain why:
- New build: has_ai_task = null (unknown yet)
- After build completes: provisionerdserver sets has_ai_task to (true|false).
My next question would be: in which case do we need to know the difference between has_ai_task = null and has_ai_task = false?
There was a problem hiding this comment.
My next question would be: in which case do we need to know the difference between has_ai_task = null and has_ai_task = false?
While has_ai_task is null (AND a build's provisioner job is in progress) we use other data (build params + template version has_ai_task) to determine if the build might be an AI task, but if it's false then we know for certain it is not. For builds at rest (i.e. no provisioner job in progress) they're functionally the same.
Signed-off-by: Danny Kopping <[email protected]>
johnstcn
approved these changes
Jun 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18453