feat: persist generated coder_app id
#18487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
commented
Jun 23, 2025
| @@ -967,6 +967,9 @@ func TestConvertResources(t *testing.T) { | |||
| if agent.GetInstanceId() != "" { | |||
| agent.Auth = &proto.Agent_InstanceId{} | |||
| } | |||
| for _, app := range agent.Apps { | |||
There was a problem hiding this comment.
For test reproducibility; see above.
johnstcn
approved these changes
Jun 23, 2025
| @@ -266,6 +266,7 @@ message App { | |||
| bool hidden = 11; | |||
| AppOpenIn open_in = 12; | |||
| string group = 13; | |||
| string id = 14; | |||
There was a problem hiding this comment.
Maybe worth mentioning the nil/zero-id behaviour in a comment here?
Signed-off-by: Danny Kopping <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #18453 and #18449
coder_appresources generate new IDs upon creation, but we don't use that value currently. We need this value to persist since the newcoder_ai_taskresource will depend on it.