chore: set wsbuilder to use preview parameters #18474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6122995 to
b5002b0
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 20, 2025
b5002b0 to
46d2751
Compare
46d2751 to
635c56b
Compare
This was referenced Jun 23, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the workspace builder to use the richer previewtypes.Parameter for dynamic parameter validation and adjusts related conversion and diagnostics logic.
- Switched
Builderto load and convert frompreviewtypes.Parameterinstead ofdatabase.TemplateVersionParameter - Appended default‐value diagnostics in the static loader
- Added preview→SDK conversion helpers in
db2sdk
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| coderd/wsbuilder/wsbuilder.go | Replaced DB parameter types with previewtypes.Parameter and updated conversion calls |
| coderd/dynamicparameters/static.go | Injected default‐value diagnostics and removed inline diagnostics in conversion fn |
| coderd/database/db2sdk/db2sdk.go | Added TemplateVersionParameterFromPreview and related option converter |
Comments suppressed due to low confidence (2)
coderd/database/db2sdk/db2sdk.go:100
- Add unit tests covering
TemplateVersionParameterFromPreview, especially around different validation rules and option conversions.
func TemplateVersionParameterFromPreview(param previewtypes.Parameter) (codersdk.TemplateVersionParameter, error) {
coderd/dynamicparameters/static.go:145
- The per-parameter conversion no longer appends validation diagnostics; consider restoring or centralizing that step to ensure non-default validations are captured.
_, param.FormType, _ = provider.ValidateFormType(provider.OptionType(param.Type), len(param.Options), param.FormType)
635c56b to
b7985e3
Compare
Dynamic parameter validation relies on the preview parameter types. These types have more information than the database. So converting from `db -> preview` is lossless. The other way around is not
b7985e3 to
467aca3
Compare
This was referenced Jun 23, 2025
johnstcn
approved these changes
Jun 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use richer
previewtypes.Parameterforwsbuilder. This is a pre-requirement to adding dynamic parameter validation.The richer type contains more information than the
dbparameter, so the conversion is lossless.Note: This just pulls out some of the diff of the larger PR in the stack