chore: remove parallel queries in the same transaction #18489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
077e337 to
a7699f5
Compare
2a37b9b to
a33fad3
Compare
a7699f5 to
f861c42
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the use of parallel queries within a single transaction to avoid concurrent query issues with PostgreSQL. It refactors query execution to run sequentially with updated error wrapping for clarity.
- Removed the use of errgroup for concurrent query execution.
- Updated error handling with xerrors.Errorf wrappers.
- Refactored variable declarations for query results.
Comments suppressed due to low confidence (3)
coderd/dynamicparameters/render.go:323
- The variable 'key' is used outside of its declaration block, making it unavailable when constructing the WorkspaceOwner struct. Consider declaring 'key' in the outer scope before its assignment so that its value can be properly accessed later.
SSHPublicKey: key.PublicKey,
coderd/dynamicparameters/render.go:311
- The 'groupNames' variable is declared locally using a short declaration, which may limit its scope. It should be declared in the outer scope to ensure it is accessible when constructing the WorkspaceOwner struct.
groupNames := make([]string, 0, len(groups))
coderd/dynamicparameters/render.go:277
- The 'ownerRoles' variable is being declared with a short assignment inside a block, which may restrict its scope and lead to a runtime error when accessed later. Consider declaring it in an outer scope so that it remains accessible when needed.
ownerRoles := make([]previewtypes.WorkspaceOwnerRBACRole, 0, len(roles))
f861c42 to
1d27539
Compare
a33fad3 to
9245e87
Compare
This was referenced Jun 23, 2025
aslilac
approved these changes
Jun 23, 2025
7349e1f to
043cd58
Compare
1d27539 to
ac9d0e6
Compare
043cd58 to
37c71f1
Compare
ac9d0e6 to
6b4dabf
Compare
6b4dabf to
1e1cb20
Compare
37c71f1 to
c1b35bf
Compare
1e1cb20 to
cb43418
Compare
Parallel concurrent queries cannot be run in the same tx
cb43418 to
a908ce6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel concurrent queries cannot be run in the same tx
Was getting this error: https://stackoverflow.com/questions/78472996/go-postgres-pq-unexpected-parse-response-c-with-queryrow