refactor: Update users page to looks like others #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
May 27, 2022
| link?: string | ||
| } | ||
|
|
||
| export const AvatarData: React.FC<AvatarDataProps> = ({ title, subtitle, link }) => { |
There was a problem hiding this comment.
I didn't find a better name for it 😓
BrunoQuaresma
commented
May 27, 2022
| "& .MuiSelect-root": { | ||
| // Adjusting padding because it does not have label | ||
| paddingTop: theme.spacing(1.5), | ||
| paddingBottom: theme.spacing(1.5), |
There was a problem hiding this comment.
Added these because the select when there is no label is very BIG.
BrunoQuaresma
commented
May 27, 2022
| @@ -61,3 +72,16 @@ export const UsersPageView: React.FC<UsersPageViewProps> = ({ | |||
| </Stack> | |||
| ) | |||
| } | |||
|
|
|||
| const useStyles = makeStyles((theme) => ({ | |||
| actions: { | |||
There was a problem hiding this comment.
This is probably something we want to extract as well.
kylecarbs
approved these changes
May 27, 2022
| link?: string | ||
| } | ||
|
|
||
| export const AvatarData: React.FC<AvatarDataProps> = ({ title, subtitle, link }) => { |
BrunoQuaresma
commented
May 27, 2022
| expect(rows).toHaveLength(MockBuilds.length) | ||
|
|
||
| // Wait for the results to be loaded | ||
| await waitFor(async () => { |
There was a problem hiding this comment.
Not sure why, but this test should had fail before since it was "wrong"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvatarDatacomponent so we can keep it consistent between templates, workspaces, and users' views.