Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: Update users page to looks like others #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrunoQuaresma merged 4 commits into from
May 27, 2022
Merged

refactor: Update users page to looks like others #1850

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
471a970
refactor: Update users page to looks like others
May 27, 2022
b052f84
Remove unused styles
May 27, 2022
339c16e
Update new to create
May 27, 2022
65323e8
Fixworkspace page test
May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixworkspace page test
  • Loading branch information
Bruno committed May 27, 2022
commit 65323e8300b0363d0374fbd609d79c89cac3d06b
8 changes: 6 additions & 2 deletions site/src/pages/WorkspacePage/WorkspacePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,12 @@ describe("Workspace Page", () => {
it("shows the timeline build", async () => {
await renderWorkspacePage()
const table = await screen.findByTestId("builds-table")
const rows = table.querySelectorAll("tbody > tr")
expect(rows).toHaveLength(MockBuilds.length)

// Wait for the results to be loaded
await waitFor(async () => {
Copy link
Copy Markdown
Contributor Author

@BrunoQuaresma BrunoQuaresma May 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but this test should had fail before since it was "wrong"

const rows = table.querySelectorAll("tbody > tr")
expect(rows).toHaveLength(MockBuilds.length)
})
})
})

Expand Down