Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

rafrdz
Copy link
Contributor

@rafrdz rafrdz commented Aug 29, 2025

In this pull request we're adding an optional tooltip field. The tooltip field is a string field (with markdown support) that will be used to display tooltips on hover over app buttons in a workspace dashboard.

Tooltip screenshot

Screenshot 2025-08-29 at 4 11 56 PM

Tooltip video

tooltip-link.mov

Issue: #18431
Related provider PR: coder/terraform-provider-coder#435

Changes

  • Added migration to add tooltip column to workspace_apps table
  • Updated queries to get/set the new tooltip column
  • Updated frontend to render tooltip as markdown (primary tool tip takes precedence over template tooltip)

Testing

  • Added storybook test for Applink markdown rendering

@rafrdz rafrdz marked this pull request as ready for review September 2, 2025 17:20
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look pretty good to me on the frontend side

Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from the standpoint of the proto. Deferring to other reviewers for the wholistic view.

@rafrdz rafrdz requested a review from Parkreiner September 5, 2025 21:14
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on my end!

{primaryTooltip ? (
primaryTooltip
) : app.tooltip ? (
<Markdown className="text-content-secondary prose-sm font-medium wrap-anywhere">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, neat. Didn't realize that we had Tailwind's typography plugin installed. Being able to use prose classes should help a lot for markdown concerns

@matifali
Copy link
Member

matifali commented Sep 8, 2025

@rafrdz, as a follow-up, please update the dogfood/coder template so we can start dogfooding. Thanks.

@rafrdz rafrdz merged commit e53bc24 into main Sep 10, 2025
36 checks passed
@rafrdz rafrdz deleted the rafrdz/tooltip-support branch September 10, 2025 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants