-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add tooltip field to workspace app that renders as markdown #19651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look pretty good to me on the frontend side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from the standpoint of the proto. Deferring to other reviewers for the wholistic view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good on my end!
{primaryTooltip ? ( | ||
primaryTooltip | ||
) : app.tooltip ? ( | ||
<Markdown className="text-content-secondary prose-sm font-medium wrap-anywhere"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, neat. Didn't realize that we had Tailwind's typography plugin installed. Being able to use prose
classes should help a lot for markdown concerns
@rafrdz, as a follow-up, please update the dogfood/coder template so we can start dogfooding. Thanks. |
In this pull request we're adding an optional
tooltip
field. Thetooltip
field is a string field (with markdown support) that will be used to display tooltips on hover over app buttons in a workspace dashboard.Tooltip screenshot
Tooltip video
tooltip-link.mov
Issue: #18431
Related provider PR: coder/terraform-provider-coder#435
Changes
tooltip
column toworkspace_apps
tabletooltip
columnTesting
Applink
markdown rendering