fix(site): await dialog close after publish to prevent act() warnings - #22334
Merged
Merged
Conversation
jeremyruppel
requested review from
DanielleMaywood,
aslilac,
jaaydenh and
jakehwll
February 26, 2026 16:46
aslilac
approved these changes
Feb 26, 2026
jaaydenh
approved these changes
Feb 27, 2026
DanielleMaywood
approved these changes
Feb 27, 2026
State updates from setIsPublishingDialogOpen, setLastSuccessfulPublishedVersion, and navigation were firing after waitFor resolved, causing sporadic act() warnings and timeouts in the publish template version tests. Fixes coder/internal#1369 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
jeremyruppel
force-pushed
the
fix/template-version-editor-page-test-flake
branch
from
February 27, 2026 13:41
01bad88 to
148c6ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State updates from setIsPublishingDialogOpen, setLastSuccessfulPublishedVersion, and navigation were firing after waitFor resolved, causing sporadic act() warnings and timeouts in the publish template version tests (or so says Claude Sonnet 4.6).
Fixes coder/internal#1369