-
Notifications
You must be signed in to change notification settings - Fork 927
Show build initiator on Workspace Build page #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also looking for design comments on the highlighting. |
4802eaf
to
c5b9aac
Compare
return { | ||
color: theme.palette.secondary.dark, | ||
initiatedBy: DisplayWorkspaceBuildInitiatedByLanguage.autostop, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling (and I know this is boring of me) is that we probably don't need to highlight these values in purple. I am concerned we will be drawing too much attention to information that, while important, is not particularly actionable. That being said, I love that you tried a different design! Maybe post this in the dev-ux channel to get more opinions - I'm not a designer by any stretch of the imagination haha.
nice job! I wonder if we want to move the new column by the |
77b539e
to
e51aba2
Compare
@Kira-Pilot Thanks for the suggestions. I am merging this for now. Let's create another issue to discuss the design, and if we reach a consensus, we can update it. |
@AbhineetJain I'm not seeing this on dev.coder.com. I'm looking at both the workspaces (plural) and workspace (singular) pages. |
@ketang The initiator is shown for each build of the workspace. You may check any of the workspace builds from the timeline table. |
Aaah okay I see now. The description says "Workspace Build" page, but I was looking at the Workspace page. I'll file an issue for that. |
This PR builds on #2438 and shows the workspace build initiator on the Workspace Build page.
Subtasks
Fixes #2029
Fixes #2410
Screenshots