Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement package and cli tool for repairing oidc links (#26418) - #26479

Merged
f0ssel merged 3 commits into
release/2.34from
backport/26418-to-2.34
Jun 17, 2026
Merged

feat: implement package and cli tool for repairing oidc links (#26418)#26479
f0ssel merged 3 commits into
release/2.34from
backport/26418-to-2.34

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Backport of #26418

Original PR: #26418 — feat: implement package and cli tool for repairing oidc links
Merge commit: 1d03e63
Requested by: @f0ssel

@github-actions
github-actions Bot requested a review from f0ssel June 17, 2026 16:33
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Docs preview

📖 View docs preview for docs/reference/cli/server.md

f0ssel and others added 2 commits June 17, 2026 13:03
@f0ssel
Merge branch 'release/2.34' into backport/26418-to-2.34
945ca9e
@f0ssel
chore(testutil/expecter): backport expecter helper for fix-oidc-links…
2c438f0 
… test

The backport of #26418 added cli/server_fix_oidc_links_test.go, which
imports github.com/coder/coder/v2/testutil/expecter. That package was
extracted on main in #25806 and does not exist on release/2.34, so the
backported test failed to compile. The compile failure broke the fmt,
gen, lint, and all test-go-pg jobs.

Backport the self-contained, test-only expecter package verbatim from
main so the test compiles and CI passes. No production code is affected.
@f0ssel Coder

f0ssel commented Jun 17, 2026

Copy link
Copy Markdown
Member

Pushed a fix for the failing CI checks.

Root cause: all failing jobs (fmt, gen, lint, required, and every test-go-pg* variant) shared a single cause. The backported cli/server_fix_oidc_links_test.go imports github.com/coder/coder/v2/testutil/expecter, a test helper that was extracted on main in #25806 and does not exist on release/2.34. The missing package made the cli test package fail to compile, which cascaded into the format, generate, lint, and test jobs.

Fix: backported the self-contained, test-only testutil/expecter package verbatim from main (expecter.go, stdbuf.go, stdbuf_internal_test.go). No production code is touched.

Local validation: make pre-commit (full gen + fmt + lint + build) passes with no generated-file drift, and TestFixOIDCLinks passes against Postgres.

Submitted by Coder Agents on behalf of @f0ssel.

@f0ssel
f0ssel merged commit 404ecb1 into release/2.34 Jun 17, 2026
27 checks passed
@f0ssel
f0ssel deleted the backport/26418-to-2.34 branch June 17, 2026 20:26
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@f0ssel f0ssel f0ssel approved these changes

Assignees

@f0ssel f0ssel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@f0ssel @Emyrk