add debounced search on type to the search bar #2703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhineetJain
approved these changes
Jun 28, 2022
Kira-Pilot
commented
Jun 29, 2022
jsjoeio
approved these changes
Jun 29, 2022
Comment on lines
-47
to
+48
| "react-helmet": "^6.1.0", | ||
| "react-helmet": "6.1.0", |
There was a problem hiding this comment.
@jsjoeio Yeah, Grey requested that I always pin dependencies. I'm down to revisit this rule in the future, but figured I'd clean up while I was in there.
| @@ -74,7 +75,7 @@ | |||
| "@types/node": "14.18.16", | |||
| "@types/react": "17.0.44", | |||
| "@types/react-dom": "17.0.16", | |||
| "@types/react-helmet": "^6.1.5", | |||
| "@types/react-helmet": "6.1.5", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2608.
Previously we were only querying on
Enteror page refresh; now we have debounced search on keystroke. Query params in URL should still update accordingly.