-
Notifications
You must be signed in to change notification settings - Fork 886
add debounced search on type to the search bar #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature and the tests are absolute ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
"react-helmet": "^6.1.0", | ||
"react-helmet": "6.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsjoeio Yeah, Grey requested that I always pin dependencies. I'm down to revisit this rule in the future, but figured I'd clean up while I was in there.
@@ -74,7 +75,7 @@ | |||
"@types/node": "14.18.16", | |||
"@types/react": "17.0.44", | |||
"@types/react-dom": "17.0.16", | |||
"@types/react-helmet": "^6.1.5", | |||
"@types/react-helmet": "6.1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
This is part of #2608.
Previously we were only querying on
Enter
or page refresh; now we have debounced search on keystroke. Query params in URL should still update accordingly.