fix(site): allow only template admins/owners to navigate to template version pages by clicking VersionRow - #27550
Merged
aqandrew merged 8 commits intoAug 4, 2026
Conversation
…e-members-shows-404-error
…e-members-shows-404-error
aqandrew
marked this pull request as ready for review
July 28, 2026 19:19
aqandrew
marked this pull request as draft
July 30, 2026 22:13
aqandrew
marked this pull request as ready for review
July 30, 2026 22:41
Contributor
Author
|
I initially got the ternary logic backwards + broke the |
jakehwll
approved these changes
Jul 30, 2026
matifali
previously requested changes
Jul 31, 2026
Contributor
Author
@matifali For sure! Making the version rows unclickable for non-admins/owners is exactly what this PR does. I think the title/description might be misleading / not specific enough, so I'll adjust them |
Member
|
Yes the title is misleading. Thanks for explaining it. |
aqandrew
deleted the
aqandrew/devex-486-versions-page-for-template-members-shows-404-error
branch
August 4, 2026 20:27
Member
|
Verified the fix on dev.coder.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes DEVEX-486
From
TemplateVersionsPage(/templates/:organization/:template/versions), users navigate to individual template version pages (TemplateVersionPage, i.e., /templates/:organization/:template/versions/:version) by clickingVersionRow.This PR makes this click-to-navigate behavior on
VersionRowavailable to admin/owner users only, per @matifali's suggestion