Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): allow only template admins/owners to navigate to template version pages by clicking VersionRow #27550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aqandrew merged 8 commits into from
Aug 4, 2026
Merged

fix(site): allow only template admins/owners to navigate to template version pages by clicking VersionRow #27550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9351e30
fix: allow only template admins/owners to navigate to template versio…
aqandrew Jul 27, 2026
be985e9
Merge branch 'main' into aqandrew/devex-486-versions-page-for-templat…
aqandrew Jul 27, 2026
ee962e3
Merge branch 'main' into aqandrew/devex-486-versions-page-for-templat…
aqandrew Jul 28, 2026
21edd5e
fix: set clickable props correctly
aqandrew Jul 30, 2026
01cc4d1
fix: add auth provider to VersionsTable stories
aqandrew Jul 30, 2026
642433d
test: add story for unclickable VersionRow
aqandrew Jul 30, 2026
ca7d5bb
feat: add aria-label to VersionRow
aqandrew Jul 30, 2026
fb5c0e3
test: add play functions to verify VersionRow's clickability
aqandrew Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion site/src/pages/TemplatePage/TemplateVersionsPage/VersionRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { InfoTooltip } from "#/components/InfoTooltip/InfoTooltip";
import { Pill } from "#/components/Pill/Pill";
import { TableCell } from "#/components/Table/Table";
import { TimelineEntry } from "#/components/Timeline/TimelineEntry";
import { useAuthenticated } from "#/hooks/useAuthenticated";
import { useClickableTableRow } from "#/hooks/useClickableTableRow";

interface VersionRowProps {
Expand All @@ -25,6 +26,7 @@ export const VersionRow: FC<VersionRowProps> = ({
onArchiveClick,
}) => {
const navigate = useNavigate();
const { permissions } = useAuthenticated();

const clickableProps = useClickableTableRow({
onClick: () => navigate(version.name),
Expand All @@ -33,7 +35,11 @@ export const VersionRow: FC<VersionRowProps> = ({
const jobStatus = version.job.status;

return (
<TimelineEntry data-testid={`version-${version.id}`} {...clickableProps}>
<TimelineEntry
data-testid={`version-${version.id}`}
aria-label={version.name}
{...(permissions.updateTemplates ? clickableProps : { clickable: false })}
>
<TableCell className="relative border-b-0 !p-0">
<div className="flex flex-row items-center justify-between gap-4 px-8 py-4">
<div className="flex flex-row items-center gap-4">
Expand Down
27 changes: 27 additions & 0 deletions site/src/pages/TemplatePage/TemplateVersionsPage/VersionsTable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,32 @@
import type { Meta, StoryObj } from "@storybook/react-vite";
import { action } from "storybook/actions";
import { within } from "storybook/test";
import {
MockCanceledProvisionerJob,
MockCancelingProvisionerJob,
MockFailedProvisionerJob,
MockNoPermissions,
MockPendingProvisionerJob,
MockPermissions,
MockRunningProvisionerJob,
MockTemplateVersion,
MockUserOwner,
} from "#/testHelpers/entities";
import { withAuthProvider } from "#/testHelpers/storybook";
import { VersionsTable } from "./VersionsTable";

const meta: Meta<typeof VersionsTable> = {
title: "pages/TemplatePage/VersionsTable",
component: VersionsTable,
parameters: {
user: MockUserOwner,
permissions: MockPermissions,
},
args: {
onPromoteClick: () => {},
onArchiveClick: () => {},
},
decorators: [withAuthProvider],
};

export default meta;
Expand All @@ -35,6 +45,23 @@ export const Example: Story = {
MockTemplateVersion,
],
},
play: async ({ canvasElement }) => {
// With permissions.updateTemplates, VersionRow is a clickable button
const canvas = within(canvasElement);
await canvas.findByRole("button", { name: MockTemplateVersion.name });
},
};

export const NoUpdatePermission: Story = {
args: { ...Example.args },
parameters: {
permissions: MockNoPermissions,
},
play: async ({ canvasElement }) => {
// Without permissions.updateTemplates, VersionRow is a non-clickable row
const canvas = within(canvasElement);
await canvas.findByRole("row", { name: MockTemplateVersion.name });
},
};

export const NoEditPermission: Story = {
Expand Down
Loading