fix: demui <OAuth2AppForm /> - #27561
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9d2fc4fd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type OAuth2AppFormValues = { | ||
| name: string; | ||
| callback_url: string; | ||
| icon: string; | ||
| }; |
There was a problem hiding this comment.
Reuse the generated OAuth2 request type
OAuth2AppFormValues re-declares the exact API payload already represented by TypesGen.PostOAuth2ProviderAppRequest and TypesGen.PutOAuth2ProviderAppRequest, even though the form passes this object directly to the create and update handlers. Using a generated request type here keeps the form contract tied to the backend schema instead of maintaining a parallel declaration.
AGENTS.md reference: site/AGENTS.md:L11-L12
Useful? React with 👍 / 👎.
| </dl> | ||
|
|
||
| <Divider css={{ borderColor: theme.palette.divider }} /> | ||
| <hr className="my-2 border-solid border-0 border-t w-full" /> |
There was a problem hiding this comment.
Use the shared separator primitive
Both new raw <hr> elements duplicate the existing #/components/Separator/Separator primitive, bypassing its centralized theme styling and Radix semantics. This de-MUI migration should use that shared component so future separator changes remain consistent across the site.
AGENTS.md reference: site/AGENTS.md:L83-L87
Useful? React with 👍 / 👎.
| autoFocus?: boolean; | ||
| }; | ||
|
|
||
| const AppFormField: FC<AppFormFieldProps> = ({ |
There was a problem hiding this comment.
quit remaking this component every five minutes :despair: just use FormField
|
and both of the codex comments make sense to me and should be addressed |
…reuse FormField and Separator primitives
jeremyruppel
left a comment
There was a problem hiding this comment.
thanks for addressing the prior feedback. LGTM!
This pull-request removes the MUI styles from the
<OAuth2AppForm />and adjacent components.