Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(site): modernize OAuth2 applications settings UI - #27562

Merged
jakehwll merged 13 commits into
mainfrom
jakehwll/oauth2app-updates
Jul 29, 2026
Merged

feat(site): modernize OAuth2 applications settings UI#27562
jakehwll merged 13 commits into
mainfrom
jakehwll/oauth2app-updates

Conversation

@jakehwll

@jakehwll jakehwll commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up to #27561

Modernizes the Deployment Settings OAuth2 Applications create/edit/list UI to match the AI Providers pattern: fat page views, card layout, and a Formik + Yup form using shared field primitives.

  • Rework CreateOAuth2AppPageView / EditOAuth2AppPageView into fat views with provider-style layout (back link, avatar + title, bordered cards, cancel/submit footer)
  • Rewrite OAuth2AppForm with Formik/Yup, FormField descriptions, and IconPickerField (live header avatar on create/edit)
  • Order edit page as settings → endpoints (Client ID / Auth / Token via CodeExample) → secrets
  • Align list page row styling and add a Callback URL column
  • Update Storybook stories for the new fat-view + form validation behavior
Old New
old-oauth2-application-create new-oauth2-application-create
old-oauth2-application-list new-oauth2-application-list
old-oauth2-application-update new-oauth2-application-update

@jakehwll
jakehwll changed the base branch from main to jakehwll/demui-oauth2appform July 28, 2026 05:03
@jakehwll jakehwll changed the title Jakehwll/oauth2app updates feat(site): modernize OAuth2 applications settings UI Jul 28, 2026
@jakehwll jakehwll added the experimental Changes that might not necessarily be merged, until its approved to proceed with. label Jul 28, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 28, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ee19603ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/pages/DeploymentSettingsPage/OAuth2AppsSettingsPage/OAuth2AppForm.tsx
Comment thread site/src/pages/DeploymentSettingsPage/OAuth2AppsSettingsPage/EditOAuth2AppPageView.stories.tsx Outdated
Comment thread site/src/pages/DeploymentSettingsPage/OAuth2AppsSettingsPage/OAuth2AppForm.tsx Outdated
@coderagents

coderagents Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/admin/integrations/oauth2-provider.md - The new client-side validation in OAuth2AppForm.tsx (isHttpUrl, allowing only http:/https:) contradicts the docs. Two places claim custom URI schemes work:

    • Line ~42 (Web UI create steps): **Callback URL**: ... or myapp://callback (native/desktop)
    • Callback URL schemes: "Custom URI schemes (myapp://, vscode://, jetbrains://, etc.) are fully supported"

    The server only blocklists schemes (codersdk.ValidateRedirectURIScheme rejects javascript:, data:, file:, ftp: and allows custom schemes), so the UI is now stricter than the API. Preferred fix is in code: relax the Yup callback_url test to match the server's blocklist behavior rather than requiring http/https. If the http/https restriction is intentional for the UI, the docs above need to state that custom schemes must be registered via the management API.

  • docs/admin/integrations/oauth2-provider.md - Line ~40 says Click Create Application on the list page, but the button is labeled Add application (pre-existing mismatch, still present after this PR).

Automated review via Coder Agents

@tracyjohnsonux

tracyjohnsonux commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

add an Oauth looks good, application list looks good, the third one (edit?) an Oauth I'm not quite crazy about. Will send notes in chat.

Base automatically changed from jakehwll/demui-oauth2appform to main July 29, 2026 14:47
@jakehwll jakehwll removed the experimental Changes that might not necessarily be merged, until its approved to proceed with. label Jul 29, 2026
@jakehwll
jakehwll merged commit 6c42309 into main Jul 29, 2026
25 of 26 checks passed
@jakehwll
jakehwll deleted the jakehwll/oauth2app-updates branch July 29, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@jeremyruppel jeremyruppel jeremyruppel approved these changes
@tracyjohnsonux tracyjohnsonux Awaiting requested review from tracyjohnsonux
@DanielleMaywood DanielleMaywood Awaiting requested review from DanielleMaywood

Assignees

@jakehwll jakehwll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakehwll @tracyjohnsonux @jeremyruppel