chore: bump @biomejs/biome from 2.4.10 to 2.5.10 in /site - #28120
Merged
github-actions[bot] merged 2 commits intoAug 31, 2026
Conversation
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/site/biomejs/biome-2.5.7
branch
2 times, most recently
from
August 17, 2026 07:18
46298a5 to
e341e48
Compare
Contributor
Author
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
2 similar comments
Contributor
Author
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
Contributor
Author
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.4.10 to 2.5.10. - [Release notes](https://github.com/biomejs/biome/releases) - [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md) - [Commits](https://github.com/biomejs/biome/commits/@biomejs/[email protected]/packages/@biomejs/biome) --- updated-dependencies: - dependency-name: "@biomejs/biome" dependency-version: 2.5.7 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/site/biomejs/biome-2.5.7
branch
from
August 31, 2026 14:11
e341e48 to
5be8379
Compare
Biome 2.5.10 changes formatting for some call expressions, adds the a11y noAmbiguousAnchorText rule, and no longer reports several previously suppressed diagnostics.
github-actions
Bot
deleted the
dependabot/npm_and_yarn/site/biomejs/biome-2.5.7
branch
August 31, 2026 17:32
ThomasK33
added a commit
that referenced
this pull request
Sep 1, 2026
Repairs two Storybook interaction tests that are deterministically broken on `main`, blocking every branch whose author runs the opt-in full pre-push hook (`make test-storybook`). ## What broke - **`TrialRequestForm > Keyboard Navigation`**: the biome 2.4.10 → 2.5.10 bump (#28120) autofixed an `aria-label` onto the premium trial form's "Learn more" docs link. The accessible name of the link is now the aria-label, so the story's exact-name query `getByRole("link", { name: "Learn more" })` no longer matches anything. - **`LicenseBannerView > Three Warnings`**: the generic-collapse refactor (#28831) renders `CollapsibleTrigger`'s own `<button>` around the `<Button>` child — invalid HTML (nested buttons) and two identically named "Show more" buttons in the accessibility tree, which the story's `getByRole("button", { name: /show more/i })` rejects as ambiguous. ## Fixes - Query the link by its real accessible name (the aria-label). - `asChild` on the collapse trigger so it decorates the existing `Button` instead of nesting one, and merge the trigger's className onto the Button. This also removes the React "button cannot be a descendant of button" hydration warning the story logs today. ## Why CI did not catch it The storybook interaction project only runs locally: `test-js` runs `vitest --project=unit`, and the CI Storybook job does pixel snapshots (and fails on dependabot PRs for the unrelated reason that `PIXEL_KEY` is unavailable to them). The full interaction suite runs in the opt-in pre-push hook, where these two failures block any push. Possibly worth a follow-up to run `vitest --project=storybook` in CI. Validation: both story files green in isolation, and the full `make pre-push` suite (3,545 story tests) passes locally with these two fixes. --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `anthropic:claude-fable-5` • Thinking: `xhigh`_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @biomejs/biome from 2.4.10 to 2.5.10.
Release notes
Sourced from @biomejs/biome's releases.
... (truncated)
Changelog
Sourced from @biomejs/biome's changelog.
... (truncated)
Commits
05797b1ci: release (#11450)5f1ed34chore: add CodSpeed and Cloudflare to sponsors (#11410)2081460ci: release (#11309)6559e6cfeat: adds theuseAstroClientOnlyDirectiveValuerule for .astro files (#11299)a8798eafeat: useNamedLayer (#11377)85aac73feat(lint): addnoUnsafeTypeAssertionrule (#11221)e65f07efeat(lint): nursery useControlLabel (#11312)ba8aa18feat(lint): adduseTailwindShorthandClasses(#10312)6b8f09cci: release (#11236)23c0369feat(lint): nursery noInvalidPropertyInitValue (#11187)