Refactor use email, password, username to constants

coder · bryphe-coder · Mar 2, 2022 · Feb 15, 2022 · Feb 15, 2022 · Feb 15, 2022
commit 66b7d60eab475fca883d2f9a35d9036295050b4c
diff --git a/site/e2e/constants.ts b/site/e2e/constants.ts
@@ -0,0 +1,5 @@
+// Default credentials and user for running tests
+export const username = "admin"
+export const password = "password"
+export const organization = "acme-crop"
+export const email = "[email protected]"
diff --git a/site/e2e/globalSetup.ts b/site/e2e/globalSetup.ts
@@ -1,4 +1,5 @@
 import { FullConfig, request } from "@playwright/test"
+import { email, username, password, organization } from "./constants"
 
 const globalSetup = async (config: FullConfig): Promise<void> => {
   // Grab the 'baseURL' from the webserver (`coderd`)
@@ -12,10 +13,10 @@ const globalSetup = async (config: FullConfig): Promise<void> => {
   // Create initial user
   await context.post("/api/v2/user", {
     data: {
-      email: "[email protected]",
-      username: "admin",
-      password: "password",
-      organization: "acme-corp",
+      email,
+      username,
+      password,
+      organization,
     },
   })
 }

diff --git a/site/e2e/tests/login.spec.ts b/site/e2e/tests/login.spec.ts
@@ -1,12 +1,13 @@
 import { test } from "@playwright/test"
 import { SignInPage } from "../pom"
+import { email, password } from "../constants"
 
 test("Login takes user to /projects", async ({ page, baseURL }) => {
   await page.goto(baseURL + "/", { waitUntil: "networkidle" })
 
   // Log-in with the default credentials we set up in the development server
   const signInPage = new SignInPage(page)
-  await signInPage.submitBuiltInAuthentication("[email protected]", "password")
+  await signInPage.submitBuiltInAuthentication(email, password)
 
   await page.waitForNavigation({ url: baseURL + "/projects", waitUntil: "networkidle" })