Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd/x/chatd): clarify the no-workspace tool error message #29237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpmct merged 2 commits into from
Sep 11, 2026
+3 −3
Merged

fix(coderd/x/chatd): clarify the no-workspace tool error message #29237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c87365b
fix(coderd/x/chatd): clarify the no-workspace tool error message
bpmct Sep 11, 2026
6855ec1
test(coderd/x/chatd): update assertion for the reworded no-workspace …
bpmct Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coderd/x/chatd/chatd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ func (c *turnWorkspaceContext) loadWorkspaceAgentLocked(
}

if !chatSnapshot.WorkspaceID.Valid {
return chatSnapshot, database.WorkspaceAgent{}, xerrors.New("no workspace is associated with this chat. Use the create_workspace tool to create one")
return chatSnapshot, database.WorkspaceAgent{}, xerrors.New("this tool requires a workspace and this chat does not have one. Use the create_workspace tool to create one")
}

if chatSnapshot.AgentID.Valid {
Expand Down
2 changes: 1 addition & 1 deletion coderd/x/chatd/store_chat_attachment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func (p *Server) storeChatAttachment(
data []byte,
) (chattool.AttachmentMetadata, error) {
if !chatSnapshot.WorkspaceID.Valid {
return chattool.AttachmentMetadata{}, xerrors.New("no workspace is associated with this chat. Use the create_workspace tool to create one")
return chattool.AttachmentMetadata{}, xerrors.New("this tool requires a workspace and this chat does not have one. Use the create_workspace tool to create one")
}

storedName, mediaType, err := chatfiles.PrepareStoredFile(name, detectName, data)
Expand Down
2 changes: 1 addition & 1 deletion coderd/x/chatd/store_chat_attachment_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func TestStoreChatAttachment_NoWorkspace(t *testing.T) {
server := &Server{db: db}

attachment, err := server.storeChatAttachment(context.Background(), database.Chat{}, "build.log", "build.log", []byte("build output"))
require.ErrorContains(t, err, "no workspace is associated")
require.ErrorContains(t, err, "this tool requires a workspace")
require.Equal(t, chattool.AttachmentMetadata{}, attachment)
}

Expand Down
Loading