chore: enable oxlint media-has-caption rule - #29249
Merged
Merged
Conversation
Enable the jsx-a11y media-has-caption rule in oxlint and make oxlint the sole enforcer by turning off Biome's useMediaCaption. Migrate the one existing suppression from a biome-ignore to an oxlint-disable comment.
DanielleMaywood
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
jsx-a11y/media-has-captionrule in oxlint, removing it from the migration backlog insite/.oxlintrc.jsonc.Following the backlog workflow, oxlint becomes the sole enforcer: Biome's
useMediaCaptionis turned off, and the one existing suppression inVideoLightbox.tsxis migrated from abiome-ignoreto anoxlint-disablecomment. That<video>is a screen recording with no caption track, so the suppression is retained with the same justification.pnpm run lint:oxlintandpnpm run lint:checkboth pass.Note
This PR was generated by Coder Agents.