Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: enable oxlint media-has-caption rule #29249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyruppel merged 1 commit into from
Sep 11, 2026
+3 −2
Merged

chore: enable oxlint media-has-caption rule #29249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions biome.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"linter": {
"rules": {
"a11y": {
"useMediaCaption": "off", // oxlint owns media-has-caption
"noSvgWithoutTitle": "off",
"useButtonType": "off",
"useSemanticElements": "off",
Expand Down
2 changes: 1 addition & 1 deletion site/.oxlintrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"autocomplete-valid": "error",
"html-has-lang": "error",
"lang": "error",
"media-has-caption": "error",

// --- complexity ---
"no-regex-spaces": "error",
Expand Down Expand Up @@ -213,7 +214,6 @@
"no-empty-interface": "off", // suspicious/noEmptyInterface (small)
"no-danger": "off", // security/noDangerouslySetInnerHtml (small: Biome suppression to migrate)
"no-noninteractive-tabindex": "off", // a11y/noNoninteractiveTabindex (small)
"media-has-caption": "off", // a11y/useMediaCaption (small)
"interactive-supports-focus": "off", // a11y/useFocusableInteractive (small)
"iframe-has-title": "off", // a11y/useIframeTitle (small)
"prefer-template": "off", // style/useTemplate (small)
Expand Down
2 changes: 1 addition & 1 deletion site/src/pages/AgentsPage/components/VideoLightbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const VideoLightbox: FC<VideoLightboxProps> = ({
{RECORDING_UNAVAILABLE_TEXT}
</div>
) : (
// biome-ignore lint/a11y/useMediaCaption: Screen recordings do not have caption tracks.
// oxlint-disable-next-line jsx-a11y/media-has-caption -- Screen recordings do not have caption tracks.
<video
src={src}
controls
Expand Down
Loading