Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Build enterprise coder binary by default #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

spikecurtis
Copy link
Contributor

Fixes #3277

We now build enterprise binary by default. If anyone wants just the AGPL code, they can use our build scripts with --agpl flag.

(Note that this PR doesn't introduce any enterprise code; the main.go is just a direct copy of the AGPL version)

@spikecurtis spikecurtis requested a review from a team as a code owner August 15, 2022 19:36
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE ✅

Signed-off-by: Spike Curtis <[email protected]>
Signed-off-by: Spike Curtis <[email protected]>
Signed-off-by: Spike Curtis <[email protected]>
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this would make Unknown appear in GitHub for the license field.

Can we make LICENSE.agpl named LICENSE instead? And still have the Enterprise license?

func main() {
rand.Seed(time.Now().UnixMicro())

cmd, err := cli.Root().ExecuteC()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan on having a separate CLI package to maintain? How do we imagine this working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will eventually be a separate enterprise cli package, because CLI commands for enterprise features will be in it. It will import all the core commands from the AGPL cli package.

@spikecurtis spikecurtis requested a review from kylecarbs August 16, 2022 20:42
@spikecurtis spikecurtis merged commit 5817c6a into main Aug 17, 2022
@spikecurtis spikecurtis deleted the spike/3277_enterprise_builds branch August 17, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enterprise license, builds, release
4 participants