-
Notifications
You must be signed in to change notification settings - Fork 888
Build enterprise coder binary by default #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Spike Curtis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE ✅
Signed-off-by: Spike Curtis <[email protected]>
Signed-off-by: Spike Curtis <[email protected]>
Signed-off-by: Spike Curtis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this would make Unknown
appear in GitHub for the license field.
Can we make LICENSE.agpl
named LICENSE
instead? And still have the Enterprise license?
func main() { | ||
rand.Seed(time.Now().UnixMicro()) | ||
|
||
cmd, err := cli.Root().ExecuteC() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan on having a separate CLI package to maintain? How do we imagine this working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will eventually be a separate enterprise cli
package, because CLI commands for enterprise features will be in it. It will import all the core commands from the AGPL cli
package.
Signed-off-by: Spike Curtis <[email protected]>
Fixes #3277
We now build enterprise binary by default. If anyone wants just the AGPL code, they can use our build scripts with
--agpl
flag.(Note that this PR doesn't introduce any enterprise code; the main.go is just a direct copy of the AGPL version)