-
Notifications
You must be signed in to change notification settings - Fork 887
fix(ui): decrease WorkspaceActions popover padding #3555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I found an issue actually - it's hard to take a screenshot of but if I click on an item in the dropdown, its style changes, so I can see a box around it, and that box has no padding, so it doesn't look good. |
Oh no! Nice find. Hmm...any suggestions? Or should I leave as is and close for now? |
Not sure, I don't even know if your change caused it. Happy to pair if you want. Actually I just checked, this ugliness is not new! So I'll approve this PR and log a new ticket. |
I'll see if I can reproduce locally first. If not, I'll ping you. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, and it uncovered another issue!
@presleyp you have 🦅👁️ for detail! I see the issue you mentioned. I don't think it was caused by my PR. I will open a separate issue and fix. I will merge this in the meantime. |
There was too much padding on the WorkspaceActions dropdown. This fixes that.
bff0812
to
cc7986d
Compare
Opened #3600 to track padding fix |
There was too much padding on the WorkspaceActions dropdown. This fixes
that.
Before
After