Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ui): decrease WorkspaceActions popover padding #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 18, 2022

There was too much padding on the WorkspaceActions dropdown. This fixes
that.

Before

before

After

after

@jsjoeio jsjoeio requested a review from a team as a code owner August 18, 2022 16:49
@jsjoeio jsjoeio marked this pull request as draft August 18, 2022 16:49
@jsjoeio jsjoeio self-assigned this Aug 18, 2022
@jsjoeio jsjoeio marked this pull request as ready for review August 18, 2022 16:54
@presleyp
Copy link
Contributor

Screen Shot 2022-08-18 at 1 28 52 PM

The padding looks good with two items. The only thing I might change (and I think this was true before as well but less so) is how the part that drops down doesn't have the same width as the select part. But it's fine to leave that for later.

@presleyp
Copy link
Contributor

I found an issue actually - it's hard to take a screenshot of but if I click on an item in the dropdown, its style changes, so I can see a box around it, and that box has no padding, so it doesn't look good.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 18, 2022

I found an issue actually - it's hard to take a screenshot of but if I click on an item in the dropdown, its style changes, so I can see a box around it, and that box has no padding, so it doesn't look good.

Oh no! Nice find. Hmm...any suggestions? Or should I leave as is and close for now?

@presleyp
Copy link
Contributor

presleyp commented Aug 18, 2022

I found an issue actually - it's hard to take a screenshot of but if I click on an item in the dropdown, its style changes, so I can see a box around it, and that box has no padding, so it doesn't look good.

Oh no! Nice find. Hmm...any suggestions? Or should I leave as is and close for now?

Not sure, I don't even know if your change caused it. Happy to pair if you want. Actually I just checked, this ugliness is not new! So I'll approve this PR and log a new ticket.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 18, 2022

Not sure, I don't even know if your change caused it. Happy to pair if you want.

I'll see if I can reproduce locally first. If not, I'll ping you. Thank you!

@jsjoeio jsjoeio marked this pull request as draft August 18, 2022 17:54
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, and it uncovered another issue!

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 19, 2022

@presleyp you have 🦅👁️ for detail! I see the issue you mentioned. I don't think it was caused by my PR. I will open a separate issue and fix.

image

I will merge this in the meantime.

There was too much padding on the WorkspaceActions dropdown. This fixes
that.
@jsjoeio jsjoeio force-pushed the jsjoeio/fix-padding branch from bff0812 to cc7986d Compare August 19, 2022 16:49
@jsjoeio jsjoeio marked this pull request as ready for review August 19, 2022 16:49
@jsjoeio jsjoeio merged commit 91bfcca into main Aug 19, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-padding branch August 19, 2022 16:58
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 19, 2022

Opened #3600 to track padding fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants