feat: add template RBAC #4125
feat: add template RBAC #4125
Conversation
This reverts commit 1f4ceee.
| @@ -0,0 +1,12 @@ | |||
| BEGIN; | |||
|
|
|||
| ALTER TABLE templates ADD COLUMN user_acl jsonb NOT NULL default '{}'; | |||
There was a problem hiding this comment.
Why store this as a massive jsonb blob instead of a table? How do we plan on efficiently getting a list of all templates the user has access to?
There was a problem hiding this comment.
It's basically the same way everything else is done. You get a list of all the templates and then you filter it through the auth filter for the subset of templates that you have access to. Just wrote a test for this here
There was a problem hiding this comment.
For workspaces, it kinda does this, but we still query by the owner so it's lessened significantly.
I guess the use-case I have in mind is 10 templates with 10 users on each... for every HTTP request we'll load 100 entries into memory and check against them? That sounds like a lot of excess when we could (I don't see why not, but maybe there's a reason) have a table that just has the user ID indexed...
There was a problem hiding this comment.
The memory overhead is unfortunate but this way plays better with rego is the short answer. We can look into rewriting it if you think it's a showstopper, I'm not sold on jsonb but joining tables doesn't play well with sqlc either so the maintainability of the code might suffer as a result of trying to glue everything together.
|
Is the frontend going to be in a separate PR? |
|
@bpmct no @BrunoQuaresma is going to push it here |
| BEGIN; | ||
|
|
||
| ALTER TABLE templates ADD COLUMN user_acl jsonb NOT NULL default '{}'; | ||
| ALTER TABLE templates ADD COLUMN is_private boolean NOT NULL default 'false'; |
| TemplateRoleAdmin TemplateRole = "admin" | ||
| TemplateRoleWrite TemplateRole = "write" | ||
| TemplateRoleRead TemplateRole = "read" | ||
| TemplateRoleDeleted TemplateRole = "" |
There was a problem hiding this comment.
Deleted should be Delete in this name pattern
| UPDATE | ||
| templates | ||
| SET | ||
| user_acl = $2 | ||
| WHERE | ||
| id = $1` |
There was a problem hiding this comment.
Why can't this be done with sqlc instead?
There was a problem hiding this comment.
because it exposes a json.RawMessage through the API. I wanted to preserve type safety as much as possible since we can't enforce the jsonb structure in the DB
| } | ||
|
|
||
| func (q *sqlQuerier) GetTemplateUserRoles(ctx context.Context, id uuid.UUID) ([]TemplateUser, error) { | ||
| const query = ` |
There was a problem hiding this comment.
I'm not convinced we should escape sqlc here... this function is only used once, so why not just do the struct conversion where it's queried from instead?
There was a problem hiding this comment.
there's unfortunately multiple problems when I tried to write this with sqlc. One is that it didn't recognize the intermediate value column in the subquery. When I tried to jank around that the resulting return type was wildly different than what I tried to express 😞
a278ae5 to
bd34d20
Compare
No description provided.