feat: paginate workspaces page #4647
Conversation
| severity={ | ||
| workspaceRefs !== undefined && workspaceRefs.length > 0 | ||
| ? "warning" | ||
| : "error" |
There was a problem hiding this comment.
What does the AlertBanner look like with the error prop passed through, but also a severity of warning? JC because I only ever tested the warning case with the text prop, as opposed to the error prop.
There was a problem hiding this comment.
Just added a story for this!
| @@ -206,160 +206,255 @@ interface WorkspacesContext { | |||
| workspaceRefs?: WorkspaceItemMachineRef[] | |||
| filter: string | |||
| getWorkspacesError?: Error | unknown | |||
| getCountError?: Error | unknown | |||
There was a problem hiding this comment.
Could these additions be pulled out into a separate machine for pagination? Not sure if there's a way to call a machine state from another machine.
There was a problem hiding this comment.
Maybe via spawn? I saw that being used below.
There was a problem hiding this comment.
Yeah, that's the idea I mentioned!
One way would be for the pagination widget to have its own machine. I believe both machines would need to be aware of the other, so we'd have to hard-code in their machine ids. I wasn't sure I liked that. I think someday XState will make stuff like that easier.
Another way would be to have a pagination machine that doesn't operate on its own, but the workspaces page invokes it. I didn't go that route only because the pagination machine would have no states, and I didn't think people would want an extra machine for something simple.
But if you're in favor, I can reconsider.
There was a problem hiding this comment.
Oh, I see! I forgot about the machine IDs.
I do like the idea of a pagination machine. Otherwise, I think we'll have to duplicate the logic you've written here to each page machine.
| getWorkspacesError: (_, event) => event.data, | ||
| }), | ||
| clearGetWorkspacesError: (context) => | ||
| assign({ ...context, getWorkspacesError: undefined }), |
There was a problem hiding this comment.
curious why we overwrite the the whole context here instead of just updating the getWorkspaceError to be undefined.
There was a problem hiding this comment.
Oh so something not great about this diff is that I used the XState editor and it rearranged some code, so some stuff looks new that isn't. This is just an old pattern that we found a better way of writing since then.
|
The empty state is a bit off - neither buttons are disabled, and when clicked, I get this error: Also, I'm surprised to see the widget for 0 entries, but if there are less than 25 entries, I don't see it. |
|
@Kira-Pilot some of the weirdness is because I got rid of conditions in the page that block the widget, but I didn't change the conditions in the widget. Partly I'm trying to leave it for that other ticket and partly I'm afraid to change the widget before testing the audit log page. I think the widget enables the page turning buttons when count is undefined, so it's usable without a count, but doesn't distinguish between 0 and undefined, so in the meantime I'm not rendering it when count is 0. |
| q.mutex.RLock() | ||
| defer q.mutex.RUnlock() | ||
|
|
||
| workspaces := make([]database.Workspace, 0) |
There was a problem hiding this comment.
You could probably save some code by just converting this from database.GetWorkspaceCountParams to database.GetWorkspaceParams and then calling q.GetAuthorizedWorkspace but completely optional.
| q.mutex.RLock() | ||
| defer q.mutex.RUnlock() | ||
|
|
||
| workspaces := make([]database.Workspace, 0) |
| -- this duplicates the filtering in GetWorkspaces | ||
| -- name: GetWorkspaceCount :one |
There was a problem hiding this comment.
I left an ad-hoc comment on the commit, but I think this is quite bug-prone.
It's not extremely obvious that you have to change this when introducing a new filter type, which could lead to a mismatch with the workspaces and count.
There was a problem hiding this comment.
Yeah, Colin thought this was the best thing for now but we have an issue to clean it up #4604
The frontend test is not ideal but I wanted to get reviews before demo time!