refactor: Improve roles UI #5576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BrunoQuaresma
commented
Jan 4, 2023
|
Adding tests to the next commit. |
presleyp
reviewed
Jan 4, 2023
BrunoQuaresma
commented
Jan 4, 2023
presleyp
reviewed
Jan 4, 2023
bpmct
reviewed
Jan 4, 2023
Co-authored-by: Ben Potter <[email protected]>
|
Fixes #4304 |
presleyp
reviewed
Jan 4, 2023
| "editUserRolesTooltip": "Edit user roles", | ||
| "fieldSetRolesTooltip": "Available roles", | ||
| "roleDescription": { | ||
| "owner": "Owner can manage all resources, including users and their permissions", |
There was a problem hiding this comment.
I tried a screen reader and it read both the title and the description, so each role name was said twice in a row. Maybe start the descriptions with "Can."
There was a problem hiding this comment.
I saw that right after clicking on merge 🤦♂️ I think this is a good suggestion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.