Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: Improve roles UI #5576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 4, 2023
Merged

refactor: Improve roles UI #5576

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d2ab1b9
Update FE with the new roles popover
BrunoQuaresma Jan 4, 2023
f5b1b23
Predicatable sorting
BrunoQuaresma Jan 4, 2023
513de24
Add predicatble sorting
BrunoQuaresma Jan 4, 2023
a23b818
Update language
BrunoQuaresma Jan 4, 2023
676d806
Add storybooks
BrunoQuaresma Jan 4, 2023
9b666f0
Add delay
BrunoQuaresma Jan 4, 2023
2fe9e51
Update site/src/i18n/en/usersPage.json
BrunoQuaresma Jan 4, 2023
48cfb1d
Fix test
BrunoQuaresma Jan 4, 2023
e21898e
Merge branch 'bq/improve-roles-ui' of github.com:coder/coder into bq/…
BrunoQuaresma Jan 4, 2023
5724c6c
Improve var name
BrunoQuaresma Jan 4, 2023
d7081f3
Improve var name
BrunoQuaresma Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions site/src/i18n/en/usersPage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
"editUserRolesTooltip": "Edit user roles",
"fieldSetRolesTooltip": "Available roles",
"roleDescription": {
"owner": "Owner can manage all the coder resources including users and their permissions",
"user-admin": "User admin can manage all the coder users and groups",
"template-admin": "Template admin can manage all the coder templates and permissions",
"owner": "Owner can manage all resources, including users and their permissions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a screen reader and it read both the title and the description, so each role name was said twice in a row. Maybe start the descriptions with "Can."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that right after clicking on merge 🤦‍♂️ I think this is a good suggestion.

"user-admin": "User admin can manage all users and groups",
"template-admin": "Template admin can manage all templates and permissions",
"auditor": "Auditor can access the audit logs",
"member": "Everybody is a member. This is a shared and default role for all the users"
"member": "Everybody is a member. This is a shared and default role for all users"
},
"member": "Member"
}