fix: make build table show empty instead of loading when none are recent #5666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be able to just fix it in the backend with: diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
index 4f057786..2f46ba6a 100644
--- a/coderd/workspacebuilds.go
+++ b/coderd/workspacebuilds.go
@@ -897,7 +897,9 @@ func (api *API) convertWorkspaceBuilds(
templateVersionByID[templateVersion.ID] = templateVersion
}
- var apiBuilds []codersdk.WorkspaceBuild
+ // Should never be nil for API consistency.
+ apiBuilds := []codersdk.WorkspaceBuild{}
+
for _, build := range workspaceBuilds {
job, exists := jobByID[build.JobID]
if !exists {
diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go
index 77183886..3f0384aa 100644
--- a/coderd/workspacebuilds_test.go
+++ b/coderd/workspacebuilds_test.go
@@ -171,6 +171,8 @@ func TestWorkspaceBuilds(t *testing.T) {
)
require.NoError(t, err)
require.Len(t, builds, 0)
+ // Must never be nil for API consistency.
+ require.NotNil(t, builds)
builds, err = client.WorkspaceBuilds(ctx,
codersdk.WorkspaceBuildsRequest{WorkspaceID: workspace.ID, Since: database.Now().Add(-time.Hour)}, |
|
@ammario ready for another look |
ammario
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5651
I couldn't figure out what on the backend was making this return null instead of [], so I just fixed the type and did a check on the frontend.