Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add debug server for tailnet coordinators #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jan 25, 2023

Implements a Tailscale-like debug server for our in-memory coordinator. This should provide some visibility into why connections could be failing.
Resolves: #5845

image

@coadler coadler requested a review from kylecarbs January 25, 2023 20:25
@coadler coadler self-assigned this Jan 25, 2023
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this form of debugging... real simple and straight-forward.

For the customer that we wanna debug this for, don't we need the HA coordinator? Can that code just be copy-pasted?

@coadler
Copy link
Contributor Author

coadler commented Jan 25, 2023

Nope, they're using the in-memory coordinator on a single node. I don't think it's a straightforward copy/paste because of the more distributed nature of the HA coordinator, so I left that out for now.

@kylecarbs
Copy link
Member

@coadler Oh, I didn't realize that. Coolio

@coadler coadler force-pushed the colin/coordinator-debug branch from 1f87720 to 69055ea Compare January 25, 2023 20:57
@coadler coadler enabled auto-merge (squash) January 25, 2023 21:22
@coadler coadler merged commit 1cd5f38 into main Jan 25, 2023
@coadler coadler deleted the colin/coordinator-debug branch January 25, 2023 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug API for agent coordinator
2 participants